Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/offline images #2582

Merged
merged 5 commits into from
Mar 18, 2019
Merged

Bugfix/offline images #2582

merged 5 commits into from
Mar 18, 2019

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Mar 12, 2019

Related issues

closes #2573

Short description and why it's useful

Fixes problems with gallery in offline mode:

  • problem that when you get back to category page, all images are the same product
  • problem that when gallery is loaded, but with no high quality image, then nothing is shown
  • problem with styles when displaying placeholder
  • problem when only single high quality image is shown, rest of it still can be low quality or placeholder

Overall - there were many edge cases. I've tried to catch all of them, hope this covers it.

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

@patzick patzick added this to the 1.9.0-rc.2 milestone Mar 12, 2019
@patzick patzick requested review from pkarw and filrak March 12, 2019 09:44
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 12, 2019
@patzick patzick merged commit 26e3334 into vuestorefront:release/1.9 Mar 18, 2019
@patzick patzick deleted the bugfix/offline-images branch March 18, 2019 06:36
@ArturDivante ArturDivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filrak filrak filrak approved these changes

@pkarw pkarw Awaiting requested review from pkarw

Assignees
No one assigned
Labels
QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Milestone
1.9.0-rc.2
Development

Successfully merging this pull request may close these issues.
3 participants
@patzick @filrak @ArturDivante