Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to scroll sidebar menu #2627

Closed
PanMisza opened this issue Mar 21, 2019 · 4 comments
Closed

Unable to scroll sidebar menu #2627

PanMisza opened this issue Mar 21, 2019 · 4 comments
Assignees
Labels
1: Easy bug Bug reports P2: Important Priority mark - still high ;) QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Milestone

Comments

@PanMisza
Copy link
Collaborator

Current behavior

I'm unable to scroll sidebar menu (eg. on mobile with horizontal orientation).

Expected behavior

Scrollable sidebar menu.

Steps to reproduce the issue

Just try to scroll on mobile with horizontal orientation.

Repository

Can you handle fixing this bug by yourself?

YES

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@PanMisza PanMisza added bug Bug reports vs-hackathon Tasks for the Hackathon P2: Important Priority mark - still high ;) 1: Easy labels Mar 21, 2019
@PanMisza PanMisza self-assigned this Mar 21, 2019
@mkaczmarekl4w
Copy link

On it

@PanMisza
Copy link
Collaborator Author

@mkaczmarekl4w
I fixed that. I assigned myself to this task after opening it :)

PanMisza added a commit to PanMisza/vue-storefront that referenced this issue Mar 21, 2019
PanMisza added a commit to PanMisza/vue-storefront that referenced this issue Mar 21, 2019
@mkaczmarekl4w
Copy link

Ahh sorry @PanMisza , I didn't notice that you were working on this issue.
It's my first contribution PR, could you let me know if I done it in the correct way?

@PanMisza
Copy link
Collaborator Author

@mkaczmarekl4w
Looks great, but we should keep the top section with close button always visible - I think it's more UX friendly.

filrak added a commit that referenced this issue Mar 24, 2019
[#2627] - fixed sidebar menu scrolling
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 24, 2019
@patzick patzick closed this as completed Mar 24, 2019
@ArturDivante ArturDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P2: Important Priority mark - still high ;) QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

4 participants