Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Page is scrolled when scrolling the side menu. #3363

Closed
2 of 5 tasks
alinadivante opened this issue Aug 13, 2019 · 0 comments
Closed
2 of 5 tasks

[iOS] Page is scrolled when scrolling the side menu. #3363

alinadivante opened this issue Aug 13, 2019 · 0 comments
Assignees
Labels
1: Easy bug Bug reports P3: Normal Priority mark - normal priority
Milestone

Comments

@alinadivante
Copy link
Collaborator

alinadivante commented Aug 13, 2019

Current behavior

On iOS devices - the page is scrolled when scrolling the side menu.

ios_scrolling

Expected behavior

Prevent page scrolling when Sidemenu is open.

Steps to reproduce the problem

  1. Go to https://test.storefrontcloud.io/ on the iPad
  2. Open the searchbar and enter "top"
  3. Scroll the results in the side menu

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Aug 13, 2019
@pkarw pkarw added P3: Normal Priority mark - normal priority 1: Easy labels Aug 13, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Aug 13, 2019
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Aug 23, 2019
@alinadivante alinadivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Aug 23, 2019
patzick added a commit that referenced this issue Aug 27, 2019
Fix body scroll lock and small visual changes
@patzick patzick closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P3: Normal Priority mark - normal priority
Projects
None yet
Development

No branches or pull requests

4 participants