Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price tiers. #1625

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Price tiers. #1625

merged 1 commit into from
Aug 23, 2018

Conversation

afirlejczyk
Copy link
Contributor

Add user groupToken to state, cache result with groupToken.

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up search.js from the content specific parameters - we should operate on groupId and groupToken on the higher level; this helper should be content agnostic

elasticQuery.body.groupToken = rootStore.state.user.groupToken
}

/* use only for cache */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn’t be here - search.js should not now about any specific content of the query. Please move it one level higher - on the hashing level

Add user groupToken to state, cache result with groupToken.
@pkarw pkarw merged commit 5ecc013 into vuestorefront:develop Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants