Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/vuepress docs #1728

Merged
merged 30 commits into from
Oct 4, 2018

Conversation

NataliaTepluhina
Copy link
Contributor

@NataliaTepluhina NataliaTepluhina commented Sep 13, 2018

Short description and why it's useful

All Vue-Storefront docs reviewed and moved to Vuepress platform. To check the current view of docs, run vuepress dev docs or npm run docs:dev

Contribution and currently important rules acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!

@filrak
Copy link
Collaborator

filrak commented Sep 19, 2018

One thing - can this vuepress instance be a separate package in monorepo so we don't need to have vuepress dependency in our main package.json?

@pkarw
Copy link
Collaborator

pkarw commented Sep 25, 2018

@NataliaTepluhina can You please add this new config option to the docs - #1764 ?

@NataliaTepluhina
Copy link
Contributor Author

NataliaTepluhina commented Sep 25, 2018

@NataliaTepluhina can You please add this new config option to the docs - #1764 ?

Added to docs.
@pkarw could you please also provide a short description for "multisiteCommonCart"?

@pkarw pkarw mentioned this pull request Oct 3, 2018
@pkarw
Copy link
Collaborator

pkarw commented Oct 4, 2018

I'm merging this in for 1.4 - please create new PR with further works

@pkarw pkarw merged commit 227a24d into vuestorefront:develop Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants