Bugfix/product zoom picture #2252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix: url_key adjustment after m2vs fix
Hofix: Improved offline mode handlers
Hotifx: docs update on `useMagentoUrlKeys`
…lem-on-checkout-page-reload Hotifx: SSR problem on checkout page on reload
pkarw
approved these changes
Jan 19, 2019
filrak
requested changes
Jan 21, 2019
| @@ -252,6 +253,15 @@ export default { | |||
| this.$store.dispatch('category/products', this.getCurrentCategoryProductQuery) | |||
| EventBus.$emitFilter('category-after-load', { store: this.$store, route: this.$route }) | |||
| } | |||
| }).catch(err => { | |||
| if (err.message.indexOf('query returned empty result') > 0) { | |||
There was a problem hiding this comment.
please move notification to theme so it can be configured (either use an overridable method for this or a callback)
There was a problem hiding this comment.
This is not a change from this issue :)
|
@ptylek can You please create new PR as this consist of some other changes not related to Yoru fix. I belive the only thing that should be in this PR is this: justify-content: space-evenly; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#2178
Short description and why it's useful
Product zoom picture is now centered
Screenshots of visual changes before/after (if there are any)
Before
After
Upgrade Notes and Changelog
Contribution and currently important rules acceptance