Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref. 2304 Fix used variable for products count in category #2326

Merged

Conversation

renatocason
Copy link
Contributor

Related issues

#2304

Short description and why it's useful

The product count on mobile was referencing a variable containing the value after pagination (50 on page load, the correct one after scrolling down). In addition, the items label wasn't using the translation function.

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@filrak
Copy link
Collaborator

filrak commented Feb 1, 2019

Thanks!

@filrak filrak merged commit d7d8754 into vuestorefront:develop Feb 1, 2019
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants