-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Module Hooks API #2330
New Module Hooks API #2330
Conversation
It's way better to pass the VSF object because it will allow us to extend However, there are currently some modules on Github created with the previous approach so we should be compatible with it (I mean with passing Vue, config .. as separate arguments). Would it be possible? |
@pkarw i already spoke with extension devs and will propose a proper PRs to their repos ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is good move:)
please remove also added storefront-ui reference, this shouldn't be added here
Related issues
Short description and why it's useful
This change is meant to prevent future problems with before/after registration hooks in modules. Grouping it into one object allows much easier modifications and future extending than relying on params order. it's the very same approach that nuxt is using with their modules.
TODO:
(describe in a few words what is this Pull Request changing and why it's useful)
Screenshots of visual changes before/after (if there are any)
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
Upgrade Notes and Changelog
Contribution and currently important rules acceptance