-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/offline products caching #2611
Hotfix/offline products caching #2611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great job!
Things we need to double check:
- error handling after asyncData refactor: non existing category (should be 404 response), non working elastic (should give us 500 error)
- urldispatcher vs beforeRouteEnter on Category if it doesn’t cause some side effects
- double check if this product/list action isn’t dispatched when browsing solely in CSR from page to page
@patzick it shouldn’t be category/products executed in beforeRouteEnter because it executed two requests - it should just execute the second one with include/excludeFields set to null - just the caching request. The first request modified current product list which causes blinkin - confirmed on next and demo |
Related issues
closes #2543, #2569, #1698
Short description and why it's useful
Things done in this PR:
Upgrade Notes and Changelog