Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/offline products caching #2611

Merged

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Mar 19, 2019

Related issues

closes #2543, #2569, #1698

Short description and why it's useful

Things done in this PR:

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

@patzick patzick requested review from pkarw and filrak March 19, 2019 23:38
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great job!

Things we need to double check:

  • error handling after asyncData refactor: non existing category (should be 404 response), non working elastic (should give us 500 error)
  • urldispatcher vs beforeRouteEnter on Category if it doesn’t cause some side effects
  • double check if this product/list action isn’t dispatched when browsing solely in CSR from page to page

@filrak filrak merged commit 5410dd6 into vuestorefront:hotfix/v1.8.4 Mar 20, 2019
@patzick patzick deleted the hotfix/offline-products-caching branch March 20, 2019 12:59
@pkarw
Copy link
Collaborator

pkarw commented Apr 4, 2019

@patzick it shouldn’t be category/products executed in beforeRouteEnter because it executed two requests - it should just execute the second one with include/excludeFields set to null - just the caching request. The first request modified current product list which causes blinkin - confirmed on next and demo

@pkarw pkarw mentioned this pull request Apr 14, 2019
5 tasks
pkarw added a commit that referenced this pull request Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants