-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/multiple redirections on my account refresh #2780
Bugfix/multiple redirections on my account refresh #2780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some naming minor issues
@@ -6,6 +6,7 @@ const getters: GetterTree<UserState, RootState> = { | |||
isLoggedIn (state) { | |||
return state.current !== null | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be named like “local_session_started” or “local_session_loaded”
export const USER_GROUP_CHANGED = SN_USER + 'GROUP_ID_CHANGED' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ - missing char in the mutation name
Cool! Merged in |
Related issues
closes #2713
Short description and why it's useful
Fixes problem with infinite redirections and redirections on SSR on account site. What has been done:
user/startSession
to async method and awaits its invocationsrouter/beforeEach
that local session data are readed before redirecting to home pageWhich environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance