Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Elastic Search Suggestions #2853

Merged
merged 3 commits into from
May 5, 2019
Merged

Feature - Elastic Search Suggestions #2853

merged 3 commits into from
May 5, 2019

Conversation

jpetar
Copy link
Contributor

@jpetar jpetar commented May 3, 2019

Short description and why it's useful

This change would allow us to implement the term suggestions from Elastic Search by handling suggest in the response.
The idea is to add the suggest query to the existing query and this feature would be it's handler.
I've successfully implemented this in a work project.

Screenshots of visual changes before/after (if there are any)

No changes made in the UI layer.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented May 3, 2019

Thanks! Now it’s fine :) please do update the changelog and it’s ready to be merged in

@patzick patzick added this to the 1.10.0-rc.1 milestone May 5, 2019
@patzick patzick merged commit 4fcbcb1 into vuestorefront:develop May 5, 2019
@jpetar jpetar deleted the feature/suggest branch May 6, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants