-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/back to top: Integrated back to top functionality #2866
Feature/back to top: Integrated back to top functionality #2866
Conversation
Hi! Thanks, please just update the Changelog :) |
Hi @pkarw, Change log added. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for the PR. I believe this could be just a simple component rather than module since there is no additional functionality there (liek vuex/router intercations etc).
Hi, @filrak, So, it should be moved in the theme core component from the module? |
Hi, @filrak, I've moved it to the theme component directory and seems working fine. Please review it and let me know. Thanks! |
Hey, thank you! ;) Now everything looks good ^^ |
Related issues
closes #2864
Short description and why it's useful
Integrated back to top functionality
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance