Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process (scoped) packages prefixed with vsf- through webpack #2875

Merged

Conversation

zimme
Copy link
Contributor

@zimme zimme commented May 8, 2019

Related issues

Fixes #2271, #2395

Short description and why it's useful

Any package in node_modules starting with vsf-* or @<scope>/vsf- will be processed by webpack

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented May 9, 2019

Thanks! Please just update the Changelog please + add a note to the docs (/docs)

Any package in `node_modules` starting with vsf-* or @<scope>/vsf- will be processed by webpack

Fixes vuestorefront#2271, vuestorefront#2395.
@zimme zimme force-pushed the zimme/process-vsf-packages-with-webpack branch from 759243e to 755f82c Compare May 9, 2019 08:42
@zimme
Copy link
Contributor Author

zimme commented May 9, 2019

Changelog and docs updates done

@zimme
Copy link
Contributor Author

zimme commented May 10, 2019

⚠️ This PR isn't ready for merge, problems has been reported and I'll look into it next week.

Probably tsconfig that needs changes.

@filrak
Copy link
Collaborator

filrak commented May 14, 2019

Thanks, this is awesome feature!

@filrak filrak merged commit e462ab0 into vuestorefront:develop May 14, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 14, 2019

@kkdg I belive we should add a note to the docs somewhere about the convention of having the vsf- prefixed modules transpiled by default

@zimme
Copy link
Contributor Author

zimme commented May 14, 2019

Did you guys fix the problem with the tsconfig file that I wrote about?

zimme added a commit to zimme/vue-storefront that referenced this pull request May 16, 2019
…s-vsf-packages-with-webpack"

This reverts commit e462ab0, reversing
changes made to cc190c9.
@zimme zimme mentioned this pull request May 16, 2019
patzick added a commit that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants