-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process (scoped) packages prefixed with vsf- through webpack #2875
Process (scoped) packages prefixed with vsf- through webpack #2875
Conversation
Thanks! Please just update the Changelog please + add a note to the docs (/docs) |
Any package in `node_modules` starting with vsf-* or @<scope>/vsf- will be processed by webpack Fixes vuestorefront#2271, vuestorefront#2395.
759243e
to
755f82c
Compare
Changelog and docs updates done |
Probably tsconfig that needs changes. |
Thanks, this is awesome feature! |
@kkdg I belive we should add a note to the docs somewhere about the convention of having the |
Did you guys fix the problem with the tsconfig file that I wrote about? |
Related issues
Fixes #2271, #2395
Short description and why it's useful
Any package in
node_modules
starting withvsf-*
or@<scope>/vsf-
will be processed by webpackScreenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance