Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor catalog module #2890
[WIP] Refactor catalog module #2890
Changes from 19 commits
5d2827c
3889092
9d2462a
16ca33e
0207857
087d45e
e834b21
d372696
59f2130
8a9d28d
d2b4664
23e70d7
c60508d
54a231b
f45fe5b
d027a4c
8e71fdf
8f9e795
f5cdd82
0a9f7d5
f979051
fece9d5
fb380e7
bd32c8c
9084808
487a847
a819f6f
25eabd7
652afe0
767aa6d
4ee0279
97e0981
adc60ad
d97b2a1
eab2243
8fd4f42
af8db3a
98034ef
35293e3
b47b34b
7d4633b
e7bdcf2
93d2588
771d734
fa52a84
f0a7259
738ddce
6208010
4a687c5
abfa197
ed6492f
0549431
447130b
6867930
c648c3c
e4665e0
2e9e140
541add0
c908fdb
02f542a
07a52d1
9d6909e
bce5a2d
d1ca817
67087ea
867f582
37aca5e
64aeff6
0fc7b6d
ba9f93b
94e5d23
3da38c0
35638d3
7329923
097eebb
cfafe84
b868176
dee2ead
e345a04
a0e993d
9659e6f
0f61390
aa41c09
8545d57
52e8854
61ae322
6153d69
779ce67
f31ac67
ddc3cde
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming, calculateCutrentCategory is totaly misleading - no clue what this getter is doing. You can calculate tax, price, any other number but find me a calculator where You can calculate category :D Makes no sense from the naming point of view. Moreover. Getters should be more obvious/self explaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover - again, with getters You can't do any async. Which makes the computations You have in it limited. I belive it should be moved to Vuex action instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, it was first what came up to my mind, we can at later stage have some discussions about naming parametrized getters. I used
calculate
insteadget
for now to have obvious info when can i just use getter and when i need to provide parameter od just use brackets :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say
get
is easier to get :D