Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed chevron arrows when only one product image #2917

Conversation

RGijsberts
Copy link
Contributor

Related issues

closes #2911

Short description and why it's useful

Issue #2911 stated that when there is only 1 product image the gallery navigation still shows even though you can't scroll. The same goes for then you reach the end of the gallery and can't scroll any further to the left or right; it would still show a navigation arrow for that direction (but in 0.3 opacity.

My fix hides the navigation arrow on class '.VueCarousel-navigation--disabled'.

The result; when there is only 1 product image OR when you can't scroll further towards a direction, it will hide the navigation arrow.

Screenshots of visual changes before/after (if there are any)

Before
Screenshot 2019-05-17 at 15 33 42

After
Screenshot 2019-05-17 at 15 32 57

Obviously on products with only 1 image both navigation arrows will be hidden.

Which environment this relates to

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@pkarw pkarw requested a review from patzick May 21, 2019 11:44
@pkarw pkarw added this to the 1.10.0-rc.1 milestone May 22, 2019
@pkarw pkarw merged commit 4e23096 into vuestorefront:develop May 22, 2019
@alinadivante alinadivante added the QA approved after merge Testers will add this label after positive check on merged changes label May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants