Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2810 order pagination #2954

Closed

Conversation

Hackbard
Copy link

Related issues

closes #2810

Short description and why it's useful

After talking to @patzick we decided to use the same look and feel from the Category Pages.
So i added the logic to show the other orders when you scroll down.

! WARNING !
We still getting all orders in once from the server/api. This is just a frontend implementation
If there is the wish to change it, there should be work on the API Layer. Couse the orders comes directly from an endpoint and not from the elastic search

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • [] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

Benjamin Klein added 4 commits May 24, 2019 13:47
Add the function bottomVisible to Helper couse we need it in two components
* Do some indention
* Use core helpers
* Add Logic to watch the scroll and determinate that we are on the end of the page and count the pagination up
Remove the bottomVisible method and use it from the core helper
@Hackbard
Copy link
Author

I will rewrite it to a module

@Hackbard Hackbard closed this May 24, 2019
@Hackbard Hackbard deleted the feature/2810-order-pagination branch May 24, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant