Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/multistore mixin outdated references #3312

Conversation

lukeromanowicz
Copy link
Contributor

Related issues

closes #3262

Short description and why it's useful

With every request, Webpack reinitializes Vue instance, router, store along with all other dependencies. Mixins kept in Vue prototype are registered only once (due to memory leaks) so they tend to keep old references. This PR fixes that.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

Important notes

We should get rid of global mixins anyway.

@lukeromanowicz lukeromanowicz changed the base branch from master to release/v1.10 July 30, 2019 17:46
@lukeromanowicz lukeromanowicz added this to the 1.10.0 milestone Jul 30, 2019
@patzick patzick merged commit 6380fc7 into vuestorefront:release/v1.10 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants