Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add test new test for multistore.ts #3352

Conversation

ResuBaka
Copy link
Collaborator

#Short description and why it's useful

Added more tests for multistore.ts. This help to check if changes does not break something.

Here I have added a small improvement to the adjustMultistoreApiUrl function where now when there is already a storeCode paramter it gets removed an changed to the new one. This does also work when there a multible storeCode parameter.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

ResuBaka and others added 4 commits August 10, 2019 15:47
…reApiUrl

The problem could have been that we send the storeCode query parameter
two times and now it gets removed bore we add a new one when needed.
When that happens there should only be one returned when we need to set
a new storeCode parameter.
@pkarw
Copy link
Collaborator

pkarw commented Aug 12, 2019

Thanks!

@pkarw pkarw merged commit 02d2e2d into vuestorefront:develop Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants