Remove Vue warning on product details because of duplicated property

[cewald]

Related issues

There is a warning in product details page because of a duplicate product property which is been defined by core/modules/compare/components/AddToCompare.ts mixin and in the products page core/pages/Product.js:

[Vue warn]: The computed property "product" is already defined as a prop.
[Vue warn]: Missing required prop: "product"

Short description and why it's useful

Just a small bugfix. I fixed it by removing the properties from the AddToCompare mixin and added it directly to the core/blocks/Compare/AddToCompare.vue component. I didn't put it in an extra mixin file because as I can see it's the only usage of this property in a component so far.

Which environment this relates to

develop:latest 09d9f8a

• Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
• RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
• Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

• No upgrade steps required (100% backward compatibility and no breaking changes)
• I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

• I read and followed contribution rules
• I read the TypeScript Action Plan and adjusted my PR according to it
• I read about Vue Storefront Modules and I am aware that every new feature should be a module

[pkarw]

Thanks!

[patzick]

@cewald please just resolve conflicts to safely merge that in

[cewald]

@patzick The conflicts are merged.