Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests in themes folder #3455

Merged

Conversation

ResuBaka
Copy link
Collaborator

@ResuBaka ResuBaka commented Sep 3, 2019

Short description and why it's useful

Fixed that you can write test in the theme and that they are going to be run when you call yarn run test:unit.

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@lukeromanowicz lukeromanowicz added this to the 1.10.1 milestone Sep 3, 2019
@ResuBaka ResuBaka marked this pull request as ready for review September 3, 2019 06:19
@patzick patzick merged commit 55d44ed into vuestorefront:hotfix/v1.10.1 Sep 3, 2019
@patzick
Copy link
Collaborator

patzick commented Sep 3, 2019

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants