Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executing localizedDispatcherRoute from localizedRoute #3548

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Remove executing localizedDispatcherRoute from localizedRoute #3548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21f541d
Remove executing localizedDispatcherRoute from localizedRoute
lukeromanowicz Sep 13, 2019
e517641
Update CHANGELOG.md
lukeromanowicz Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Refactored vuex newsletter module - @andrzejewsky (#3337)
- Optimized fetching product data on homepage - @lukeromanowicz (#3512)
- `localizedRoute()` now supports path (and prefers over fullPath) in LocalizedRoute objects - @lukeromanowicz (#3515)
- `localizedRoute()` doesn't return urlDispatcher routes anymore. Use localizedDispatcherRoute instead - @lukeromanowicz (#3548)

## [1.10.2] - 2019.09.06

Expand Down
4 changes: 0 additions & 4 deletions core/lib/multistore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,6 @@ export function localizedRoute (routeObj: LocalizedRoute | string | RouteConfig
if ((routeObj as LocalizedRoute).fullPath && !(routeObj as LocalizedRoute).path) { // support both path and fullPath
routeObj['path'] = (routeObj as LocalizedRoute).fullPath
}

if ((routeObj as LocalizedRoute).path && config.seo.useUrlDispatcher) {
return localizedDispatcherRoute(Object.assign({}, routeObj) as LocalizedRoute, storeCode)
}
}

if (storeCode && config.defaultStoreCode !== storeCode && config.storeViews[storeCode] && config.storeViews[storeCode].appendStoreCode) {
Expand Down