Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cmsBlock getter cmsBlockIdentifier which called it self #3683

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Fixed cmsBlock getter cmsBlockIdentifier which called it self #3683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5257589
Fixed cmsBlock getter cmsBlockIdentifier which called it self
ResuBaka Oct 4, 2019
e4678a7
Update CHANGELOG.md
ResuBaka Oct 4, 2019
eb7cb4d
Merge branch 'release/v1.11' into fix/cms-block-getter-throws-error
ResuBaka Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed deprecated getter in cmsBlock store - @resubaka (#3683)
- Fixed problem around dynamic urls when default storeView is set with appendStoreCode false and url set to / . @resubaka (#3685)

## [1.11.0-rc.1] - 2019.10.03
Expand Down
2 changes: 1 addition & 1 deletion core/modules/cms/store/block/getters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const getters: GetterTree<CmsBlockState, RootState> = {
// @deprecated
cmsBlocks: (state, getters) => getters.getCmsBlocks,
// @deprecated
cmsBlockIdentifier: (state, getters) => (identifier) => getters.cmsBlockIdentifier(identifier),
cmsBlockIdentifier: (state, getters) => (identifier) => getters.getCmsBlockByIdentifier(identifier),
// @deprecated
cmsBlockId: (state, getters) => (id) => getters.getCmsBlockById(id),
getCmsBlockByIdentifier: (state) => (identifier) =>
Expand Down