Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prefech dayjs locales #3728

Merged
merged 3 commits into from
Oct 25, 2019
Merged

remove prefech dayjs locales #3728

merged 3 commits into from
Oct 25, 2019

Conversation

gibkigonzo
Copy link
Contributor

@gibkigonzo gibkigonzo commented Oct 18, 2019

Related issues

closes #3498

Short description and why it's useful

Added function that creates regexp with needed dayjs locales

QA

  1. open http://next.storefrontcloud.io, clear cache and refresh page
  2. open Elements tab in devtools and expand head tag. There should be loaded a lot of dayjs...js files
  3. checkout on current branch, prepare env (yarn build and yarn start)
  4. make 1 and 2 step on current branch page
  5. In head should be loaded only needed dayjs...js files based on config.
  6. Previous steps could be tested with different config:
  • without specified defaultLocale in config.i18n.defaultLocale (should load only en file, because it's fallback language)
  • without multistore config (should load en and one specified in config.i18n.defaultLocale)
  • with multistore config (should load en and all specified in storeView i18n.defaultLocale)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibkigonzo looks quite good 👍 can you please add some test scenario for the QA team?

@andrzejewsky andrzejewsky added this to the 1.11.0-rc2 milestone Oct 18, 2019
@andrzejewsky andrzejewsky added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Oct 18, 2019
@gibkigonzo
Copy link
Contributor Author

@andrzejewsky sure :) just added

@alinadivante alinadivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Oct 23, 2019
@andrzejewsky andrzejewsky merged commit 3933f4f into vuestorefront:release/v1.11 Oct 25, 2019
@jpkempf jpkempf mentioned this pull request Jan 21, 2020
3 tasks
rebinti pushed a commit to rebinti/vue-storefront that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants