Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the readability of 'getShippingDetails()' and 'updateDetails' method of UserShippingDetails component #3771

Merged
merged 9 commits into from
Nov 21, 2019

Conversation

adityasharma7
Copy link
Contributor

@adityasharma7 adityasharma7 commented Nov 1, 2019

closes #3770

Related issues

closes #

Short description and why it's useful

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@andrzejewsky andrzejewsky requested a review from pkarw November 6, 2019 09:58
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the changes suggested by @andrzejewsky in order to merge this

@andrzejewsky andrzejewsky added this to the 1.11.0 milestone Nov 7, 2019
@adityasharma7 adityasharma7 changed the title Improve the readability of getShippingDetails() method Improve the readability of 'getShippingDetails()' and 'updateDetails' method of UserShippingDetails component Nov 11, 2019
@adityasharma7
Copy link
Contributor Author

@andrzejewsky @pkarw I have updated the PR with changes suggested by @andrzejewsky. Apart from that, I have also simplified the code for updateDetails() method along with the update to the changelogs.

@andrzejewsky andrzejewsky added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Nov 11, 2019
@andrzejewsky
Copy link
Contributor

@adityasharma7 thanks! @alinadivante please have look at checkout process, request data for shipping details and whether entire placing a order works as beforehand, thanks!

@ArturDivante ArturDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Nov 21, 2019
@andrzejewsky andrzejewsky self-requested a review November 21, 2019 12:53
@andrzejewsky andrzejewsky merged commit 31b4a6c into vuestorefront:release/v1.11 Nov 21, 2019
@adityasharma7 adityasharma7 deleted the vsf#3770 branch November 22, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants