-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the readability of 'getShippingDetails()' and 'updateDetails' method of UserShippingDetails component #3771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the changes suggested by @andrzejewsky in order to merge this
@andrzejewsky @pkarw I have updated the PR with changes suggested by @andrzejewsky. Apart from that, I have also simplified the code for updateDetails() method along with the update to the changelogs. |
@adityasharma7 thanks! @alinadivante please have look at checkout process, request data for shipping details and whether entire placing a order works as beforehand, thanks! |
closes #3770
Related issues
closes #
Short description and why it's useful
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance