Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix for Cannot assign to read only property 'storeCode' #3748 #3783

Merged
merged 3 commits into from
Nov 6, 2019
Merged

hot fix for Cannot assign to read only property 'storeCode' #3748 #3783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca1fab8
PAT-1721 Issue #3748 apply hot fix for Cannot assign to read only pro…
yuriboyko Nov 5, 2019
9236ddd
PAT-1721 Issue #3748 add changelogs
yuriboyko Nov 5, 2019
c870480
Merge branch 'hotfix/v1.10.5' into hotfix/issue-3748
pkarw Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [1.10.5] - unreleased

### Fixed
- Disable product mutation when assigning product variant - @gibkigonzo (#3735)
- Fix issue with Cannot assign to read only property 'storeCode' - @yuriboyko (#3748)
- Render correct category links when multistore is active - @gibkigonzo (#3753)
- Disable product mutation when assigning product variant - @gibkigonzo (#3735)

Expand Down
6 changes: 5 additions & 1 deletion core/lib/multistore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,13 @@ export async function prepareStoreView (storeCode: string): Promise<StoreView> {
}
const storeViewHasChanged = !rootStore.state.storeView || rootStore.state.storeView.storeCode !== storeCode
if (storeCode) { // current store code
if ((storeView = config.storeViews[storeCode])) {
const currentStoreView = config.storeViews[storeCode]
if (currentStoreView) {
storeView = Object.assign({}, currentStoreView);
storeView.storeCode = storeCode
rootStore.state.user.current_storecode = storeCode
} else {
console.warn(`Not found 'storeView' matching the given 'storeCode': ${storeCode}`)
}
} else {
storeView.storeCode = config.defaultStoreCode || ''
Expand Down