Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for trailing slash #5372

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Support for trailing slash #5372

merged 2 commits into from
Jan 8, 2021

Conversation

Fifciu
Copy link
Collaborator

@Fifciu Fifciu commented Jan 5, 2021

Related Issues

closes #4684

Short Description and Why It's Useful

PR based on #4716
It adds support for the trailing slash. Routes will work both with and without trailing slash. We didn't want to force anything on each route because some projects might require trailing slash for a PLP but not for a PDP. If you want to apply redirects, we are going to prepare a simple doc about that: https://github.com/vuestorefront/vue-storefront/issues/5370

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@Fifciu Fifciu added the VSF1 Issues in regards to VSF1 label Jan 5, 2021
@Fifciu Fifciu requested a review from gibkigonzo January 5, 2021 15:03
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Fifciuu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Fifciu Fifciu mentioned this pull request Jan 5, 2021
6 tasks
@Fifciu Fifciu merged commit dec6d43 into hotfix/v1.12.3 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VSF1 Issues in regards to VSF1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants