Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-tab cart-sync in multi-store environment #5711

Conversation

cewald
Copy link
Contributor

@cewald cewald commented Mar 26, 2021

Related Issues

Related to #3838 & #4083

Short Description of the PR

The multi-tab cart-sync feature wouldn't work in a multistore-environment with disabled storeViews.commonCache feature as the keys in local-storage are prefixed with the store-code like de-shop/cart/current-cart.

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

* Only trigger event if it is for the current store in case you have opened tabs for multiple store-views
Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cewald ,
it looks very promising. However, could you please rebase it and target to the 1.12.3? We would apply support for multistore for this very similar one too: https://github.com/vuestorefront/vue-storefront/pull/5352/files which is one the 1.12.3

@cewald cewald changed the base branch from develop to hotfix/v1.12.3 April 6, 2021 11:02
@cewald cewald changed the base branch from hotfix/v1.12.3 to develop April 6, 2021 11:02
@cewald cewald closed this Apr 6, 2021
@cewald cewald deleted the bugfix/multi-tab-cart-sync-in-multistore branch April 6, 2021 11:17
@cewald
Copy link
Contributor Author

cewald commented Apr 6, 2021

Hello @cewald ,
it looks very promising. However, could you please rebase it and target to the 1.12.3? We would apply support for multistore for this very similar one too: https://github.com/vuestorefront/vue-storefront/pull/5352/files which is one the 1.12.3

I've opened up a new PR #5732 using hotfix/v1.12.3 as base branch – I've also updated the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants