Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add subscribe to newsletter modal on home page #6082

Merged
merged 12 commits into from
Aug 25, 2021

Conversation

AdamPawlinski
Copy link
Contributor

@AdamPawlinski AdamPawlinski commented Jul 15, 2021

Related Issues

closes #EN-311

Short Description of the PR

Add modal for subscribing newsletter on Home Page following the figma design.

Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I tested manually my code and it works well with both:
  • Default Theme
  • Capybara Theme
  • I have written test cases for my code

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


AdamPawlinski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added commercetools Next Issues/bugs for Vue Storefront Next labels Jul 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2021

💙 vsf-next-demo successfully deployed at

@AdamPawlinski AdamPawlinski changed the title [WIP] fix: add subscrbie to newsletter modal on home page [WIP] fix: add subscribe to newsletter modal on home page Jul 16, 2021
@github-actions github-actions bot added the core label Jul 16, 2021
@AdamPawlinski AdamPawlinski changed the title [WIP] fix: add subscribe to newsletter modal on home page fix: add subscribe to newsletter modal on home page Jul 16, 2021
@AdamPawlinski
Copy link
Contributor Author

I had to remove mobile observer that causes inifite loop error. Now it should work properly.

@AdamPawlinski AdamPawlinski requested a review from Baroshem August 4, 2021 11:29
Copy link
Contributor

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small proposition for better readability and follow Vue standards :)

packages/core/nuxt-theme-module/theme/pages/Home.vue Outdated Show resolved Hide resolved
@AdamPawlinski AdamPawlinski requested a review from Baroshem August 5, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boilerplate commercetools core Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants