-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add subscribe to newsletter modal on home page #6082
Conversation
AdamPawlinski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
💙 vsf-next-demo successfully deployed at |
packages/core/nuxt-theme-module/theme/components/NewsletterModal.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/NewsletterModal.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/NewsletterModal.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/NewsletterModal.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/NewsletterModal.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/NewsletterModal.vue
Outdated
Show resolved
Hide resolved
…into add-newsletter-modal-on-home-page
packages/core/nuxt-theme-module/theme/components/NewsletterModal.vue
Outdated
Show resolved
Hide resolved
I had to remove mobile observer that causes inifite loop error. Now it should work properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small proposition for better readability and follow Vue standards :)
Related Issues
closes #EN-311
Short Description of the PR
Add modal for subscribing newsletter on Home Page following the figma design.
Screenshots of Visual Changes before/after (if There Are Any)
Pull Request Checklist