Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commercetools): add lineitem channels #6161

Merged
merged 15 commits into from
Aug 10, 2021
Merged

feat(commercetools): add lineitem channels #6161

merged 15 commits into from
Aug 10, 2021

Conversation

alefbarbeli
Copy link
Contributor

@alefbarbeli alefbarbeli commented Aug 5, 2021 •
edited
Loading

Related Issues

resolves #EN-380
resolves #EN-384

Short Description of the PR

Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I tested manually my code and it works well with both:
  • Default Theme
  • Capybara Theme
  • I have written test cases for my code

@github-actions github-actions bot added commercetools core Next Issues/bugs for Vue Storefront Next labels Aug 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2021 •
edited
Loading

💙 vsf-next-demo successfully deployed at

@github-actions github-actions bot added the docs Tasks regarding documentation label Aug 10, 2021
@github-actions github-actions bot removed the core label Aug 10, 2021
@alefbarbeli alefbarbeli marked this pull request as ready for review August 10, 2021 06:07
Fifciu
Fifciu approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Baroshem
Baroshem approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@andrzejewsky andrzejewsky merged commit 95405b8 into EN-356-implement-useStore-commercetools Aug 10, 2021
@bloodf bloodf deleted the EN-380-lineitem-channel branch September 24, 2021 12:54
@lsliwaradioluz lsliwaradioluz mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloodf bloodf bloodf left review comments

@Baroshem Baroshem Baroshem approved these changes

@Fifciu Fifciu Fifciu approved these changes

@andrzejewsky andrzejewsky andrzejewsky approved these changes

@igorwojciechowski igorwojciechowski Awaiting requested review from igorwojciechowski

@vn-vlad vn-vlad Awaiting requested review from vn-vlad

@filipsobol filipsobol Awaiting requested review from filipsobol

Assignees
No one assigned
Labels
commercetools docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alefbarbeli @bloodf @andrzejewsky @Fifciu @Baroshem