Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add debounce for updateCartQuantity #6233

Conversation

igorwojciechowski
Copy link
Contributor

@igorwojciechowski igorwojciechowski commented Aug 24, 2021

Description

Adds debounce for updateCartQuantity action. Quantity input in Cart Sidebar is no longer immediately disabled after inserting a value - request is delayed by 500ms, therefore enabling inserting more than just one digit value.

Related Issue

Closes #6226

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added core Next Issues/bugs for Vue Storefront Next labels Aug 24, 2021
@github-actions
Copy link
Contributor

💙 vsf-next-demo successfully deployed at

@igorwojciechowski igorwojciechowski merged commit d5072a7 into next Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cart] Customer cannot insert multi digit quantity into input
3 participants