Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove download all button from the order list in my account #6246

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Remove download all button from the order list in my account #6246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab30fef
fix: remove 'download all' button
lukaszjedrasik Aug 31, 2021
2dd6fa1
update changelog
lukaszjedrasik Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/docs/changelog/6246.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
module.exports = {
description: 'Remove "download all" button from the order list in my account',
link: 'https://github.com/vuestorefront/vue-storefront/pull/6246',
isBreaking: false,
breakingChanges: [],
author: 'Łukasz Jędrasik',
linkToGitHubAccount: 'https://github.com/lukaszjedrasik'
};
21 changes: 6 additions & 15 deletions packages/core/nuxt-theme-module/theme/pages/MyAccount/OrderHistory.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,7 @@
v-for="tableHeader in tableHeaders"
:key="tableHeader"
>{{ tableHeader }}</SfTableHeader>
<SfTableHeader class="orders__element--right">
<span class="smartphone-only">{{ $t('Download') }}</span>
<SfButton
class="desktop-only sf-button--text orders__download-all"
@click="downloadOrders()"
>
{{ $t('Download all') }}
</SfButton>
</SfTableHeader>
<SfTableHeader class="orders__element--right" />
</SfTableHeading>
<SfTableRow v-for="order in orders" :key="orderGetters.getId(order)">
<SfTableData v-e2e="'order-number'">{{ orderGetters.getId(order) }}</SfTableData>
Expand All @@ -74,9 +66,6 @@
<span :class="getStatusTextClass(order)">{{ orderGetters.getStatus(order) }}</span>
</SfTableData>
<SfTableData class="orders__view orders__element--right">
<SfButton class="sf-button--text smartphone-only" @click="downloadOrder(order)">
{{ $t('Download') }}
</SfButton>
<SfButton class="sf-button--text desktop-only" @click="currentOrder = order">
{{ $t('View details') }}
</SfButton>
Expand All @@ -102,7 +91,8 @@ import {
SfTabs,
SfTable,
SfButton,
SfProperty
SfProperty,
SfLink
} from '@storefront-ui/vue';
import { computed, ref } from '@vue/composition-api';
import { useUserOrder, orderGetters } from '<%= options.generate.replace.composables %>';
Expand All @@ -115,7 +105,8 @@ export default {
SfTabs,
SfTable,
SfButton,
SfProperty
SfProperty,
SfLink
},
setup() {
const { orders, search } = useUserOrder();
Expand Down Expand Up @@ -195,7 +186,7 @@ export default {
@include for-desktop {
&__element {
&--right {
--table-column-flex: 0;
--table-column-flex: 1;
text-align: right;
}
}
Expand Down