Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @vue-storefront/health-check module #6563

Merged
merged 6 commits into from
Dec 14, 2021

Conversation

lukaszjedrasik
Copy link
Contributor

@lukaszjedrasik lukaszjedrasik commented Dec 13, 2021

Description

Related Issue

closes #6541

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next labels Dec 13, 2021
@github-actions
Copy link
Contributor

💙 vsf-next-demo successfully deployed at

@lukaszjedrasik lukaszjedrasik changed the title feat: add @vue-storefront/health-check module feat: add @vue-storefront/health-check module Dec 13, 2021
@PiotrGrzywa
Copy link
Contributor

Should we have some changelog here ?

@lukaszjedrasik lukaszjedrasik force-pushed the feat/os-207-health-check branch from 7f889e7 to e4bfbb6 Compare December 13, 2021 15:41
@lukaszjedrasik lukaszjedrasik merged commit e706d2e into main Dec 14, 2021
@lukaszjedrasik lukaszjedrasik deleted the feat/os-207-health-check branch December 14, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing health check in the core module
4 participants