Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autochange language SSR #6633

Merged
merged 2 commits into from
Feb 16, 2022
Merged

fix: autochange language SSR #6633

merged 2 commits into from
Feb 16, 2022

Conversation

dawid-ziobro
Copy link
Contributor

Description

After switching "autoChangeCookie" to false, some cookies were still changing.
This fix was needed in order to develop the "Multi Currency" feature.

Related Issue

https://vsf.atlassian.net/browse/CT-137
https://vsf.atlassian.net/browse/CT-114

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next labels Feb 14, 2022
@lukasborawski lukasborawski changed the title Fix/autochange language ssr fix: autochange language ssr Feb 14, 2022
@lukasborawski lukasborawski changed the title fix: autochange language ssr fix: autochange language SSR Feb 14, 2022
Copy link
Collaborator

@lukasborawski lukasborawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@github-actions
Copy link
Contributor

💙 vsf-next-demo successfully deployed at

@dawid-ziobro dawid-ziobro merged commit 83c4747 into main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants