Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new performance-oriented docs #6636

Merged
merged 13 commits into from
Mar 8, 2022

Conversation

filipsobol
Copy link
Contributor

PR based on #6628

@github-actions github-actions bot added docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next labels Feb 16, 2022
@github-actions
Copy link
Contributor

💙 vsf-next-demo successfully deployed at

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ filipsobol
❌ piotr-grzywa
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@filrak filrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally, a great piece of content and I am super happy we are having it. Left some minor comments

packages/core/docs/performance/other-optimizations.md Outdated Show resolved Hide resolved
packages/core/docs/performance/other-optimizations.md Outdated Show resolved Hide resolved

Use `keep-alive` headers and don't close the connection when multiple requests are sent to the same domain.

By default, when user enters your website, browser needs to create new connection for every resource request (JS, CSS, images etc). This requires performing three-way handshake every time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, when user enters your website, browser needs to create new connection for every resource request (JS, CSS, images etc). This requires performing three-way handshake every time.
By default, when user enters your website, browser needs to create new connection for every resource request (JS, CSS, images etc). This requires performing three-way handshake every time that makes the responses slower.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not up to date, content was changed.

@PiotrGrzywa PiotrGrzywa requested a review from filrak March 7, 2022 07:13
@filipsobol filipsobol merged commit c7a03fd into main Mar 8, 2022
@filipsobol filipsobol deleted the 20220216-add-performance-docs branch March 8, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants