-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get api host from middleware url #6680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
docs
Tasks regarding documentation
Next
Issues/bugs for Vue Storefront Next
labels
Mar 21, 2022
💙 vsf-next-demo successfully deployed at |
filipsobol
reviewed
Mar 21, 2022
filipsobol
reviewed
Mar 21, 2022
filipsobol
reviewed
Mar 21, 2022
filipsobol
reviewed
Mar 21, 2022
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
Should we also update this part of the VSF docs about separating server-middleware? |
@lsliwaradioluz i don't think so, nothing changes for this case. |
lukasborawski
approved these changes
Mar 22, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Base url for middleware is no longer computed and is not based on headers anymore.
Now
middlewareUrl
is used instead and this config option is now required.Configuration in
nuxt.config.js
has to be extended.Related Issue
CT-208
Motivation and Context
Headers can be overridden which can lead to security issues.
How Has This Been Tested?
Types of changes
Changelog
Tests
Code standards
Docs