Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get api host from middleware url #6680

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Conversation

dawid-ziobro
Copy link
Contributor

Description

Base url for middleware is no longer computed and is not based on headers anymore.
Now middlewareUrl is used instead and this config option is now required.
Configuration in nuxt.config.js has to be extended.

Related Issue

CT-208

Motivation and Context

Headers can be overridden which can lead to security issues.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next labels Mar 21, 2022
@github-actions
Copy link
Contributor

💙 vsf-next-demo successfully deployed at

dawid-ziobro and others added 2 commits March 21, 2022 15:18
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@lsliwaradioluz
Copy link
Collaborator

Should we also update this part of the VSF docs about separating server-middleware?

image

@dawid-ziobro
Copy link
Contributor Author

@lsliwaradioluz i don't think so, nothing changes for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants