Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix middleware URL generation #6688

Merged
merged 78 commits into from
Apr 7, 2022
Merged

refactor: fix middleware URL generation #6688

merged 78 commits into from
Apr 7, 2022

Conversation

bloodf
Copy link
Contributor

@bloodf bloodf commented Mar 26, 2022 •
edited
Loading

Description

fixed the middleware URL generation in the nuxt component

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@bloodf bloodf self-assigned this Mar 26, 2022
@github-actions github-actions bot added core Next Issues/bugs for Vue Storefront Next labels Mar 26, 2022
@github-actions
Copy link
Contributor

💙 vsf-next-demo successfully deployed at

@bloodf bloodf changed the title refactor(core): fix missing getBaseUrl method refactor(core): fix middleware URL generation Mar 26, 2022
@bloodf @dawid-ziobro
Update packages/core/core/src/utils/nuxt/index.ts
c601eab 
Co-authored-by: daaf <44862757+dawid-ziobro@users.noreply.github.com>
bloodf and others added 15 commits March 29, 2022 11:04
@bloodf @lukasborawski
Update packages/core/core/src/utils/nuxt/_proxyUtils.ts
420877d 
Co-authored-by: Lukas Borawski <lukas.borawski@gmail.com>
@bloodf
refactor(core): changed the way to fetch url from config
a01f548
@bloodf
Merge branch 'main' into fix-missing-baseUrl
c859284
@bloodf
refactor(core): added URL to generate Urls
a0f5436
@bloodf
refactor(core): removed URL checking, only validantion
7b03a04
@bloodf
refactor(nuxt-module): added URL check as a hook
a3db3d3
@bloodf
refactor(nuxt-module): fixed URL generation in hook
3f5341f
@bloodf
refactor(core): slim down the code for URL generation
76cf61b
@bloodf
chore: removed non-used plugin is-https
b4845dd
@bloodf
refactor(core): fixed regex
48c6f80
@bloodf
refactor(core): fixed tests for new approach
45540e3
@bloodf
refactor(nuxt-module): fixed configuration merge
8598230
@bloodf
refactor(nuxt-module): fixed configuration merge
e444ca1
@bloodf
refactor(nuxt-module): changed merge strategy
3abe973
@bloodf
refactor(nuxt-module): changed merge strategy
4e74a3d
@lukasborawski @filipsobol
docs: headers-security.md update
bc8b757 
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
lukasborawski and others added 5 commits April 6, 2022 11:36
@lukasborawski @filipsobol
docs: headers-security.md update
44643aa 
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@lukasborawski @filipsobol
docs: headers-security.md update
27d6c3b 
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@lukasborawski @filipsobol
docs: headers-security.md update
5c22975 
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@lukasborawski
chore: version bump to 2.5.12-c
5801cfa
@lukasborawski
chore: versions alignment
8627931
lukasborawski and others added 2 commits April 6, 2022 18:37
@lukasborawski @filipsobol
docs: update api-url.md
d1435b8 
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@lukasborawski @filipsobol
docs: update api-url.md
7b2ee67 
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@lukasborawski @dawid-ziobro
chore: removed un chaining
4474d9a 
Co-authored-by: daaf <44862757+dawid-ziobro@users.noreply.github.com>
@lukasborawski @dawid-ziobro
chore: interpolation
35e6493 
Co-authored-by: daaf <44862757+dawid-ziobro@users.noreply.github.com>
Fifciu
Fifciu requested changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also add a field for middlewareUrl for request from the server? Communication between nuxt server renderer and our middleware could go through internal network then.

packages/core/middleware/nuxt/index.js Outdated Show resolved Hide resolved
packages/core/middleware/src/createServer.ts Outdated Show resolved Hide resolved
@lukasborawski lukasborawski merged commit 12feb05 into main Apr 7, 2022
@lukasborawski lukasborawski deleted the fix-missing-baseUrl branch April 7, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzejewsky andrzejewsky andrzejewsky left review comments

@dawid-ziobro dawid-ziobro dawid-ziobro approved these changes

@Fifciu Fifciu Fifciu approved these changes

@filipsobol filipsobol filipsobol approved these changes

@lukasborawski lukasborawski lukasborawski approved these changes

Assignees

@bloodf bloodf

Labels
core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bloodf @lukasborawski @filipsobol @andrzejewsky @Fifciu @dawid-ziobro