Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): restore middleware definition in integrationPlugin #6702

Merged
merged 2 commits into from
May 20, 2022

Conversation

bloodf
Copy link
Contributor

@bloodf bloodf commented Apr 8, 2022

Description

Restore the definition of axios BaseURL if the middlewareURL or SSRMiddlewareURL is defined.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added core Next Issues/bugs for Vue Storefront Next labels Apr 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

💙 vsf-next-demo successfully deployed at

Copy link
Collaborator

@lukasborawski lukasborawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tested?

@bloodf
Copy link
Contributor Author

bloodf commented May 15, 2022

It's tested?

It was when created. But I have to retest to make sure. It adds a missing code only.

@lukasborawski lukasborawski merged commit 4d0b314 into main May 20, 2022
@lukasborawski lukasborawski deleted the middleware-restore branch May 20, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants