Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): configurable cookie attributes #6715

Merged
merged 5 commits into from
May 6, 2022

Conversation

MarcinSulowski
Copy link
Contributor

Description

This PR makes it possible to overwrite the default attributes and create new ones for the locale, country and currency cookies.

Related Issue

CORE-6

Motivation and Context

This supports the use case where you have to set cookies on a parent domain to support differing subdomains for different sections of the website (setting the domain attribute for cookies). Additionally, you can overwrite the existing attributes or set new ones, if need be.

How Has This Been Tested?

Tested locally with the commercetools integration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next labels May 6, 2022
@MarcinSulowski MarcinSulowski changed the title Feat/configurable cookie attributes Feat(core): configurable cookie attributes May 6, 2022
@MarcinSulowski MarcinSulowski changed the title Feat(core): configurable cookie attributes feat(core): configurable cookie attributes May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

💙 vsf-next-demo successfully deployed at

Copy link
Collaborator

@lukasborawski lukasborawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dawid-ziobro
Copy link
Contributor

Changelog is missing.

MarcinSulowski and others added 3 commits May 6, 2022 12:37
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
@MarcinSulowski MarcinSulowski requested a review from filipsobol May 6, 2022 11:02
@MarcinSulowski MarcinSulowski merged commit fb7fdd5 into main May 6, 2022
@MarcinSulowski MarcinSulowski deleted the feat/core-6-set-cookie-options branch May 6, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core docs Tasks regarding documentation Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants