-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): configurable cookie attributes #6715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinSulowski
requested review from
lukasborawski,
bloodf,
filipsobol and
dawid-ziobro
May 6, 2022 09:08
github-actions
bot
added
core
docs
Tasks regarding documentation
Next
Issues/bugs for Vue Storefront Next
labels
May 6, 2022
MarcinSulowski
changed the title
Feat/configurable cookie attributes
Feat(core): configurable cookie attributes
May 6, 2022
MarcinSulowski
changed the title
Feat(core): configurable cookie attributes
feat(core): configurable cookie attributes
May 6, 2022
💙 vsf-next-demo successfully deployed at |
lukasborawski
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
filipsobol
reviewed
May 6, 2022
Changelog is missing. |
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
dawid-ziobro
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible to overwrite the default attributes and create new ones for the locale, country and currency cookies.
Related Issue
CORE-6
Motivation and Context
This supports the use case where you have to set cookies on a parent domain to support differing subdomains for different sections of the website (setting the
domain
attribute for cookies). Additionally, you can overwrite the existing attributes or set new ones, if need be.How Has This Been Tested?
Tested locally with the commercetools integration.
Types of changes
Checklist:
Changelog
Tests
Code standards
Docs