Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed disabled redirects #6730

Merged
merged 1 commit into from
May 23, 2022

Conversation

dawid-ziobro
Copy link
Contributor

@dawid-ziobro dawid-ziobro commented May 20, 2022

Description

With redirects disabled, cookies were still set by accepted languages.
This was causing a mix of languages where page default lang is en and accepted language or cookie is set to de. Some texts were in de and some in en language.

Related Issue

CT-192

How Has This Been Tested?

Tested with CT.
Steps to reproduce a bug:

  1. In nuxt.config.js set:
  • autoRedirectByLocale: false.
  • defaultLocale to other than browser preferred language, f.e. if browser language is en, set default locale to de
  1. Run project.
  2. Open home page.
  3. Page should not redirect to en version.
  4. Texts will have mixed languages, english with deutch.

Expected result is to have texts in one language,

Screenshots:

mixed langs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added core Next Issues/bugs for Vue Storefront Next labels May 20, 2022
@github-actions
Copy link
Contributor

💙 vsf-next-demo successfully deployed at

@dawid-ziobro dawid-ziobro merged commit d2402de into main May 23, 2022
@lukasborawski lukasborawski deleted the fix/ct-192-fix-for-disabled-redirects branch May 31, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants