Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: namespaced extensions #7013

Merged
merged 4 commits into from
Jan 17, 2024
Merged

feat: namespaced extensions #7013

merged 4 commits into from
Jan 17, 2024

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jan 9, 2024 •
edited
Loading

closing: https://vsf.atlassian.net/browse/IN-3857

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bartoszherba bartoszherba force-pushed the feat/extensions-namespacing branch from 5efd394 to 8ee7114 Compare January 9, 2024 10:52
@bartoszherba bartoszherba requested a review from a team January 9, 2024 10:53
@bartoszherba bartoszherba marked this pull request as ready for review January 9, 2024 10:53
Fifciu
Fifciu requested changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Small changes requested

docs/content/3.middleware/2.guides/3.extensions.md Outdated Show resolved Hide resolved
packages/middleware/__tests__/integration/createServer.spec.ts Outdated Show resolved Hide resolved
packages/middleware/__tests__/integration/createServer.spec.ts Outdated Show resolved Hide resolved
packages/middleware/src/types/common.ts Outdated Show resolved Hide resolved
packages/middleware/__tests__/integration/createServer.spec.ts Show resolved Hide resolved
@bartoszherba bartoszherba force-pushed the feat/extensions-namespacing branch from 3c031fa to 5ce5ca8 Compare January 12, 2024 08:20
@bartoszherba bartoszherba force-pushed the feat/extensions-namespacing branch from 5ce5ca8 to ac5cafb Compare January 12, 2024 08:22
@bartoszherba bartoszherba requested review from Fifciu and a team January 12, 2024 11:34
WojtekTheWebDev
WojtekTheWebDev requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changeset

WojtekTheWebDev
WojtekTheWebDev reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of the changeset, I really like the change, gj!

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1404544

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/middleware Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

WojtekTheWebDev
WojtekTheWebDev approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

WojtekTheWebDev
WojtekTheWebDev requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stopping merge for a little bit, as I'm receiving the feedback that extensions should be namespaced by default, which would make it a BC. Need to confirm.

WojtekTheWebDev
WojtekTheWebDev approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's introduce it as a non-breaking change.

@bartoszherba bartoszherba merged commit 1e9fe53 into main Jan 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsliwaradioluz lsliwaradioluz lsliwaradioluz approved these changes

@WojtekTheWebDev WojtekTheWebDev WojtekTheWebDev approved these changes

@Fifciu Fifciu Fifciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bartoszherba @Fifciu @WojtekTheWebDev @lsliwaradioluz