-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use closure to create multistore extension #7026
Conversation
π¦ Changeset detectedLatest commit: af36087 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the nits are on code that you didn't write so feel free to just merge without addressing them
π Linked issue
β Type of change
π Description
[CHANGED] We standardized the way of creating and configuring multistore extension.
Previously, the extension was created by importing
multistoreExtension
from@vue-storefront/multistore
and passing it to theextensions
function.Configuration was passed to the extension by adding
multistore
property to theconfiguration
object.Now, the extension is created by calling
createMultistoreExtension
from@vue-storefront/multistore
and passing the multistore configuration to it.π Checklist