-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor vite styles plugin #338
base: master
Are you sure you want to change the base?
Conversation
uhmm, with |
@KaelWD now it works in Vite and Nuxt with and without SSR (no vue-router warnings for virtual SASS files requests), updated linked repos PR if you want to check it (using same logic here). |
Thanks @userquin, I just tested modern sass api on my sample repo here - https://github.com/pinegrow/pg-vue-vuetify. Especially, when I work on vuetify with Vue Designer, sass updates use to be very sluggish. With sass modern api, I feel its pretty smooth, HMR is quite fast as well. Can't wait for this update to be out, especially for Nuxt app where more auto-magic happens. |
This PR includes:
refactor logic to remove any virtual usage: using target mapping from✔️ we only need to fix vue router warnings when running Nuxt with SSR enabled.css
to.sass
+ writing temporary SASS files when using SASS Variables (will solve missing sass source warnings and SSR problems when using Nuxt)none
and object styles notation at onceuseViteFileImport
in shared optionsYou can check the following repos and the corresponding PR:
supersedes #332