fix(VList): don't trigger keyboard events on disabled items (#15339)

resolves #15322 Co-authored-by: lampdev <orders@lampdev.com>
vuetifyjs · Jun 29, 2022 · 817df79 · 817df79
1 parent ff519c6
commit 817df79
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/packages/vuetify/src/components/VList/VListItem.ts b/packages/vuetify/src/components/VList/VListItem.ts
@@ -168,10 +168,12 @@ export default baseMixins.extend<options>().extend({
     data[this.to ? 'nativeOn' : 'on'] = {
       ...data[this.to ? 'nativeOn' : 'on'],
       keydown: (e: KeyboardEvent) => {
-        /* istanbul ignore else */
-        if (e.keyCode === keyCodes.enter) this.click(e)
+        if (!this.disabled) {
+          /* istanbul ignore else */
+          if (e.keyCode === keyCodes.enter) this.click(e)
 
-        this.$emit('keydown', e)
+          this.$emit('keydown', e)
+        }
       },
     }
 

diff --git a/packages/vuetify/src/components/VList/__tests__/VListItem.spec.ts b/packages/vuetify/src/components/VList/__tests__/VListItem.spec.ts
@@ -234,4 +234,16 @@ describe('VListItem.ts', () => {
     wrapper2.vm.toggle()
     expect(wrapper2.vm.isActive).toBeTruthy()
   })
+
+  it('should not react to keydown.enter when disabled', () => {
+    const click = jest.fn()
+    const wrapper = mountFunction({
+      methods: { click },
+      propsData: { disabled: true },
+    })
+
+    wrapper.trigger('keydown.enter')
+
+    expect(click).not.toHaveBeenCalled()
+  })
 })