Skip to content

Commit

Permalink
fix(application-service): overwrite location sizes when registering n…
Browse files Browse the repository at this point in the history
…ew app components

the current functionality updates the public values by reducing everything registered for each
component. this is not necessary and will be removed in the v3 refactor

fixes #9797
  • Loading branch information
johnleider committed Jan 16, 2020
1 parent 75f6197 commit b1058f3
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
11 changes: 4 additions & 7 deletions packages/vuetify/dev/App.vue
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
<template>
<v-app>
<v-content>
<playground></playground>
</v-content>
<keep-alive>
<router-view></router-view>
</keep-alive>
</v-app>
</template>

<script>
import Playground from './Playground'
export default {
components: {
Playground
}
},
}
</script>
3 changes: 3 additions & 0 deletions packages/vuetify/dev/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import Vuetify from 'vuetify'
import * as locales from '../src/locale'
import router from './router'
import '@mdi/font/css/materialdesignicons.css'
import Playground from './Playground'

Vue.component('playground', Playground)

Vue.config.performance = true

Expand Down
4 changes: 2 additions & 2 deletions packages/vuetify/dev/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import Router from 'vue-router'
Vue.use(Router)

const component1 = {
template: `<div class="title">Page 1</div>`,
template: `<v-content><playground /></v-content>`,
}
const component2 = {
template: `<div class="title">Page 2</div>`,
template: `<v-content><playground /></v-content>`,
}

const router = new Router({
Expand Down
2 changes: 1 addition & 1 deletion packages/vuetify/src/services/application/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class Application extends Service implements IApplication {
location: TargetProp,
size: number
) {
this.application[location][uid] = size
this.application[location] = { [uid]: size }

this.update(location)
}
Expand Down

0 comments on commit b1058f3

Please sign in to comment.