fix(VRating): check if half-increments prop is used alongside rtl

fixes #10093
vuetifyjs · Jan 10, 2020 · ddf3aec · ddf3aec
1 parent df502ff
commit ddf3aec
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/vuetify/src/components/VRating/VRating.ts b/packages/vuetify/src/components/VRating/VRating.ts
@@ -159,7 +159,14 @@ export default mixins(
     },
     genHoverIndex (e: MouseEvent, i: number) {
       let isHalf = this.isHalfEvent(e)
-      if (this.$vuetify.rtl) isHalf = !isHalf
+
+      if (
+        this.halfIncrements &&
+        this.$vuetify.rtl
+      ) {
+        isHalf = !isHalf
+      }
+
       return i + (isHalf ? 0.5 : 1)
     },
     getIconName (props: ItemSlotProps): string {

diff --git a/packages/vuetify/src/components/VRating/__tests__/VRating.spec.ts b/packages/vuetify/src/components/VRating/__tests__/VRating.spec.ts
@@ -181,6 +181,7 @@ describe('VRating.ts', () => {
 
   it('should check for half event in rtl', () => {
     const wrapper = mountFunction({
+      propsData: { halfIncrements: true },
       mocks: {
         $vuetify: {
           rtl: true,