Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] RTL stepper is broken #10098

Closed
Nabeel20 opened this issue Jan 2, 2020 · 1 comment · Fixed by #10145, skyYaga/skdvin-webapp#18, skyYaga/skdvin-webapp#21 or anyulled/reactivewebflux#5 · May be fixed by andrebaldo/python-vue-spa-boilerplate#3
Labels
C: VStepper VStepper good first issue A quick-win fix that would be great for new contributors rtl S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@Nabeel20
Copy link

Nabeel20 commented Jan 2, 2020

Environment

Vuetify Version: 2.1.15
Vue Version: 2.6.10
Browsers: Google Chrome
OS: Windows

Steps to reproduce

• just tried to add a stepper to RTL vue component.

Expected Behavior

To Respect RTL guidelines and achieve animation and elements in the right direction and place.

Actual Behavior

The left line won't get to right and the animation sometimes not working properly.

Reproduction Link

https://codepen.io/Nabeel2020_XD/pen/zYxEQRp?&editable=true&editors=101#anon-signup

@ghost ghost added the S: triage label Jan 2, 2020
@jacekkarczmarczyk jacekkarczmarczyk added C: VStepper VStepper rtl T: bug Functionality that does not work as intended/expected good first issue A quick-win fix that would be great for new contributors and removed S: triage labels Jan 3, 2020
@ant1m4tt3r
Copy link
Contributor

ant1m4tt3r commented Jan 7, 2020

I think you can solve this by overriding some css:

.theme--light.v-stepper--vertical .v-stepper__content:not(:last-child) {
    /* border-left: 1px solid rgba(0,0,0,.12); This is the old value  */
    border-right: 1px solid rgba(0,0,0,.12);
}

.v-stepper--vertical .v-stepper__content {
     /* margin: -8px 36px -16px -36px; This is the old value */
    margin: -8px -36px -16px 36px; !important
}

I'll work on a permanent fix.

ant1m4tt3r pushed a commit to ant1m4tt3r/vuetify that referenced this issue Jan 7, 2020
Added a right border on RLT for the VStepper component and also fixed its margins

fix vuetifyjs#10098
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Jan 11, 2020
johnleider pushed a commit that referenced this issue Jan 21, 2020
fixes #10098

- Added a right border on RLT for the VStepper component and also fixed its margins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VStepper VStepper good first issue A quick-win fix that would be great for new contributors rtl S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
3 participants