Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] "@click:append" on VAutocomplete removes aria-hidden=true #10391

Closed
mseele opened this issue Jan 30, 2020 · 1 comment · Fixed by #10439
Closed

[Bug Report] "@click:append" on VAutocomplete removes aria-hidden=true #10391

mseele opened this issue Jan 30, 2020 · 1 comment · Fixed by #10439
Assignees
@KaelWD
Labels
C: VIcon VIcon C: VSelect VSelect T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone
v2.2.x

Comments

@mseele
Copy link
Contributor

mseele commented Jan 30, 2020

Environment

Vuetify Version: 2.2.8
Vue Version: 2.6.11
Browsers: Chrome 79.0.3945.130
OS: Windows 10

Steps to reproduce

Click into "DropDown Focus Bug" Input field and click "Tab" to move focus to next control

Expected Behavior

Focus jumps to next input field

Actual Behavior

DropDown Icon of Input Field gets the focus (because of @click:append="console.log('click')")

Reproduction Link

https://codepen.io/mseele/pen/NWPZWEV

Other comments

Please see the second Input Field with out @click:append="console.log('click')" where the issue is gone
@ghost ghost added the S: triage label Jan 30, 2020
@KaelWD
Copy link
Member

KaelWD commented Jan 30, 2020

86133ea

Related: #10379

@KaelWD KaelWD added C: VAutocomplete VAutocomplete T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke C: VSelect VSelect C: VIcon VIcon and removed S: triage C: VAutocomplete VAutocomplete labels Jan 30, 2020
@johnleider johnleider added this to the v2.2.x milestone Feb 2, 2020
@KaelWD KaelWD mentioned this issue Feb 3, 2020
Merged
4 tasks
johnleider added a commit that referenced this issue Feb 4, 2020
@KaelWD @johnleider
fix(VIcon): use a button element for clickable icons (#10439)
1596e55 
fixes #10265
fixes #10391
fixes #10398

* fix(VIcon): use a button element for clickable icons

* test: update snapshots

* refactor(VIcon): change focus style

following spec on this makes it hard to track focused icons, other frameworks use an outline similar
to btn instead, team agrees

* fix: fix double focus/ripple in v-rating, focus style updates

* style(VIcon): change ordering

Co-authored-by: John Leider <john@vuetifyjs.com>
@snyk-bot snyk-bot mentioned this issue Feb 27, 2020
Merged
This was referenced Mar 9, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VIcon VIcon C: VSelect VSelect T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Milestone
v2.2.x
Development

Successfully merging a pull request may close this issue.

fix: use a button element for clickable icons vuetifyjs/vuetify
3 participants
@johnleider @mseele @KaelWD