Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Incosistent animation for bottom sheets #10506

Closed
funkybg opened this issue Feb 7, 2020 · 1 comment · Fixed by skyYaga/skdvin-webapp#23 or anyulled/reactivewebflux#5 · May be fixed by SigmaITC/competencebyjava-front-end#8
Closed

[Bug Report] Incosistent animation for bottom sheets #10506

funkybg opened this issue Feb 7, 2020 · 1 comment · Fixed by skyYaga/skdvin-webapp#23 or anyulled/reactivewebflux#5 · May be fixed by SigmaITC/competencebyjava-front-end#8
Assignees
@KaelWD
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone
v2.2.x

Comments

@funkybg
Copy link

funkybg commented Feb 7, 2020

Environment

Vuetify Version: 2.2.11
Vue Version: 2.6.11
Browsers: Chrome 79.0.3945.130
OS: Mac OS 10.15.3

Steps to reproduce

  1. Click open persistent
  2. Close the sheet
  3. Open again
  4. Repeat

Expected Behavior

Bottom sheet open and close animation should be consistent.

Actual Behavior

On initial open, the sheet slides up.
On consecutive opens / closes the sheet fades in and out

Reproduction Link

https://codepen.io/mmartev/pen/mdJydxV
@ghost ghost added the S: triage label Feb 7, 2020
@KaelWD KaelWD added C: VDialog VDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke and removed S: triage labels Feb 7, 2020
@KaelWD KaelWD self-assigned this Feb 7, 2020
@KaelWD KaelWD mentioned this issue Feb 9, 2020
Closed
@KaelWD KaelWD added this to the v2.2.x milestone Feb 10, 2020
@KaelWD
Copy link
Member

KaelWD commented Feb 10, 2020 •
edited
Loading

John's fault: https://github.com/vuetifyjs/vuetify/pull/8823/files/efb7adb8ffea7faf9cf78ad639f9f70bdf571976#diff-6d73f6698e69f2b6c718dfed6b89cd34, 5cd4486

@KaelWD KaelWD closed this as completed in 1491914 Feb 10, 2020
This was referenced Feb 11, 2020
Closed
Closed
Logikgate pushed a commit to flypapertech/vuetify that referenced this issue Feb 19, 2020
@KaelWD @Logikgate
fix(VDialog): show transition on close
d1d98fc 
fixes vuetifyjs#10506
whoistobias pushed a commit to whoistobias/vuetify that referenced this issue Feb 26, 2020
@KaelWD @whoistobias
fix(VDialog): show transition on close
522b098 
fixes vuetifyjs#10506
This was referenced Mar 9, 2020
Merged
Closed
Closed
Closed
Merged
@snyk-bot snyk-bot mentioned this issue Mar 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Milestone
v2.2.x
2 participants
@funkybg @KaelWD