fix(VRangeSlider): add unique id for inputs elements #10654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Andrew Henry <AMajesticPotatoe@gmail.com>
|
Hey @VSymonenko, TravisBuddy Request Identifier: e3521020-57d8-11ea-acab-ef795e2c3319 |
johnleider
requested changes
Feb 24, 2020
packages/vuetify/src/components/VRangeSlider/__tests__/VRangeSlider.spec.ts
Show resolved
Hide resolved
johnleider
changed the title
|
changed logic as in the suggestion, see cfeb50b |
johnleider
requested changes
Feb 25, 2020
Co-Authored-By: John Leider <john@vuetifyjs.com>
johnleider
approved these changes
Feb 25, 2020
whoistobias
pushed a commit
to whoistobias/vuetify
that referenced
this pull request
Feb 26, 2020
fixes vuetifyjs#6843 * fix(breakpoint): Passing 0 value to scrollBarWidth * refactor(breakpoint): Passing 0 to scrollBarWidth * fix(vrangeslider): add uniq id for inputs elements re vuetifyjs#6843 * Update packages/vuetify/src/components/VRangeSlider/VRangeSlider.ts Co-Authored-By: Andrew Henry <AMajesticPotatoe@gmail.com> * test(vrangeslider): update snapshots * refactor(vrangeslider): cleared code style * refactor(vrangeslider): assignment ids algorithm moved to direct logic * Update packages/vuetify/src/components/VRangeSlider/VRangeSlider.ts Co-Authored-By: John Leider <john@vuetifyjs.com> Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com> Co-authored-by: Jacek Karczmarczyk <jkarczm@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com>
|
thanks all), sorry I didn't have time for requests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #6843
Motivation and Context
Elements ids should be unique on a page
How Has This Been Tested?
Created a unit test
Markup:
No additional configuration required
Types of changes
Checklist:
masterfor bug fixes and documentation updates,devfor new features and backwards compatible changes andnextfor non-backwards compatible changes).