Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VRangeSlider): add unique id for inputs elements #10654

Merged
merged 14 commits into from
Feb 25, 2020
Merged

fix(VRangeSlider): add unique id for inputs elements #10654

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dc056cf
fix(breakpoint): Passing 0 value to scrollBarWidth
VSymonenko Oct 18, 2019
3cce634
Merge branch 'master' into master
VSymonenko Oct 25, 2019
26ebeba
refactor(breakpoint): Passing 0 to scrollBarWidth
VSymonenko Oct 25, 2019
6d4aa97
Merge github.com:vuetifyjs/vuetify
VSymonenko Dec 25, 2019
afb5d6c
Merge branch 'master' of github.com:vuetifyjs/vuetify
VSymonenko Jan 18, 2020
3c6e2e4
Merge branch 'master' of github.com:vuetifyjs/vuetify
VSymonenko Feb 23, 2020
c6e90a9
fix(vrangeslider): add uniq id for inputs elements
VSymonenko Feb 23, 2020
fcf2158
Update packages/vuetify/src/components/VRangeSlider/VRangeSlider.ts
VSymonenko Feb 24, 2020
88fe135
test(vrangeslider): update snapshots
VSymonenko Feb 24, 2020
cfee7bc
Merge branch 'master' into master
VSymonenko Feb 24, 2020
abf6a61
refactor(vrangeslider): cleared code style
VSymonenko Feb 25, 2020
cfeb50b
refactor(vrangeslider): assignment ids algorithm moved to direct logic
VSymonenko Feb 25, 2020
22be934
Merge branch 'master' of github.com:vuetifyjs/vuetify
VSymonenko Feb 25, 2020
69d10df
Update packages/vuetify/src/components/VRangeSlider/VRangeSlider.ts
jacekkarczmarczyk Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/vuetify/src/components/VRangeSlider/VRangeSlider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ export default VSlider.extend({
input.data = input.data || {}
input.data.attrs = input.data.attrs || {}
input.data.attrs.value = this.internalValue[i]
input.data.attrs.id = i ? `input-max-${this._uid}` : `input-min-${this._uid}`
jacekkarczmarczyk marked this conversation as resolved.
Show resolved Hide resolved

return input
})
Expand Down
8 changes: 8 additions & 0 deletions packages/vuetify/src/components/VRangeSlider/__tests__/VRangeSlider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,4 +220,12 @@ describe('VRangeSlider.ts', () => {
expect(wrapper.vm.internalValue).toEqual([0, 0])
})
})

// https://github.com/vuetifyjs/vuetify/issues/6843
it('should be uniq id', async () => {
const wrapper = mountFunction()
const [min, max] = wrapper.vm.genInput()
VSymonenko marked this conversation as resolved.
Show resolved Hide resolved

expect(min.data.attrs.id).not.toEqual(max.data.attrs.id)
})
})
8 changes: 4 additions & 4 deletions ...ges/vuetify/src/components/VRangeSlider/__tests__/__snapshots__/VRangeSlider.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ exports[`VRangeSlider.ts should render a vertical slider 1`] = `
<div class="v-input__slot">
<div class="v-slider v-slider--vertical theme--light">
<input value="0"
id="input-29"
id="input-min-29"
readonly="readonly"
tabindex="-1"
>
<input value="0"
id="input-29"
id="input-max-29"
readonly="readonly"
tabindex="-1"
>
Expand Down Expand Up @@ -68,13 +68,13 @@ exports[`VRangeSlider.ts should render disabled slider 1`] = `
<div class="v-input__slot">
<div class="v-slider v-slider--horizontal v-slider--disabled theme--light">
<input value="0"
id="input-33"
id="input-min-33"
disabled="disabled"
readonly="readonly"
tabindex="-1"
>
<input value="0"
id="input-33"
id="input-max-33"
disabled="disabled"
readonly="readonly"
tabindex="-1"
Expand Down